imdbphp icon indicating copy to clipboard operation
imdbphp copied to clipboard

Added method mainPictures back

Open duck7000 opened this issue 3 years ago • 8 comments

  • added mainPictures back, output array is the same as previous method. This will get the 12 main images from the title page.

Maybe the if checks need some attention?

duck7000 avatar Jul 16 '21 10:07 duck7000

@jreklund Thanks for your comments.

Wow that's a lot issues, i'll look in to that

duck7000 avatar Jul 16 '21 11:07 duck7000

It will work without most of the modifications, we will however save some microseconds and get cleaner code with these modifications thought. :)

Thanks the hard work you are putting into the library lately! <3

jreklund avatar Jul 16 '21 11:07 jreklund

Cleaner code is absolutely fine, and i learned a lot lately here! Thanks!

Well i'm trying to make it better/more useful and better to understand (i hate preg_matches, very hard to understand) And i'm used to write code in a simple matter, so that i later on still understand what it does, although i perfectly understand ++ i still write it all out.

With your help i can get a long way to make/fix problems so i thank you too!

duck7000 avatar Jul 16 '21 12:07 duck7000

It might be a idea to include the image id in the output array? So in your application users can use that to name the images according to their imdb image id? It is just a thought

duck7000 avatar Jul 26 '21 09:07 duck7000

Is there any problem with this PR? I tested too. it's working.

alr2413 avatar Sep 15 '21 17:09 alr2413

As far as i know it is working but @jreklund haven't reviewed this any further. So i don't really know what is going on but there may be a valid reason for this?

@jreklund , @tboothman Can this PR and possibly my other PR's been reviewed? I do understand that it will cost your time, but it would be nice to make some valid changes to imdbphp? I'm just politely asking though

duck7000 avatar Sep 15 '21 19:09 duck7000

on request @Thomasdouscha i will reopen

duck7000 avatar Feb 16 '22 20:02 duck7000

This will need a test but i only do that after this is final reviewed.

duck7000 avatar Mar 14 '22 18:03 duck7000

@jreklund Last try, can/will you merge this or not?

duck7000 avatar Oct 10 '22 10:10 duck7000