php-rethink-ql icon indicating copy to clipboard operation
php-rethink-ql copied to clipboard

Published 20 hours ago • verified publisher icon tbolier

Upgrade test suite

Open Th3Mouk opened this issue 7 years ago • 3 comments

Issue summary

Currently tests don't passed in PHP 7.2 for RowTests.php. PHP 7.3 is now in beta so we must include it too.

If Scrutinizer don't provide the feature, we might consider taking the tests under Travis CI.

Issue checklist

  • [x] Add PHP 7.2 tests
  • [ ] Add PHP 7.3 tests

Th3Mouk avatar Aug 08 '18 10:08 Th3Mouk

I will look into this in the coming days.

Thanks for reporting!

tbolier avatar Aug 20 '18 10:08 tbolier

I have assigned this issue to milestone 2.1

However 7.2 will be supported ASAP

tbolier avatar Sep 08 '18 20:09 tbolier

I have test 7.2.9 and it worked fine without issues.

tbolier avatar Sep 08 '18 21:09 tbolier