Thomas Boerger

Just taking the tag like it is would also be some kind of breaking change... It would silently build another tag as the people out there might already expect ;)

@bradrydzewski if you are fine with this change go ahead and merge it.

If you change docker.go you must update the other commands as well. Beside that your use case is not really the focus of that plugin. Not sure how @bradrydzewski things...

Ah scratch that, the other plugins based on this just wrap the docker plugin binary.

As the current labels are deprecated I tend to drop them entirely and maybe add a flag to enable the replacement for the deprecated labels defined at https://github.com/opencontainers/image-spec/blob/master/annotations.md

There is already an insecure flag.

The option is name insecure-registry, so why do you name it mirror now?

There are unrelated changes included, you got to rebase properly before I'm able to give a real review.

Codewise it looks good to me, but not sure about the security impact. @bradrydzewski your opinion?

I'm fine with directly tagging all versions, but even if we focus it on that it's a duplicate of https://github.com/drone-plugins/drone-docker/pull/174