Thomas Boerger
Thomas Boerger
You are right, cors is listening for options requests, but maybe you are running into https://github.com/gin-contrib/cors/blob/master/config.go#L33
I like the comment at https://github.com/Rob--W/cors-anywhere/issues/86#issuecomment-336505344 :)
The session store gets created once, so why should there be an issue within this middleware?
I have already approved it, but I prefer to merge it by somebody else.
Why do you need to authenticate at this stage?
Why don't you just define the logging driver on Docker daemon level? IMHO it doesn't make sense to define that per container.
I can't merge on this repo, it's up to @bradrydzewski
And I think if you rebase the PR to resolve the conflicts we can finally get it merged.
The review of googlesource mentioned a comment like this: ``` SystemCertPool returns an error on Windows ``` Somebody got to test that carefully before merging the PR, I don't know...
Just checked the Go source code, it still errors hard on windows: https://github.com/golang/go/blob/master/src/crypto/x509/cert_pool.go#L106-L109