react-select-search icon indicating copy to clipboard operation
react-select-search copied to clipboard

improve type definitions

Open manvydasu opened this issue 4 years ago • 5 comments

#158

manvydasu avatar Jan 24 '21 12:01 manvydasu

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tbleckert/react-select-search/ge3ozrqot
✅ Preview: https://react-select-search-git-fork-manvydasu-master.tbleckert.vercel.app

vercel[bot] avatar Jan 24 '21 12:01 vercel[bot]

@tbleckert Hi, this wrong type is blocking us from using this library with TypeScript. Can you take a look and review it or merge it?

I see there's a small merge conflict, but it's very minor. If you need help with it because you're busy, I'll gladly help.

Thanks, we love this library (although using it with non-TS JS now :smile: )!

ramonsnir avatar Aug 19 '21 12:08 ramonsnir

@tbleckert any update on this?

AndrejGajdos avatar Sep 29 '21 08:09 AndrejGajdos

Why is this still open?

potatosenior avatar Mar 25 '22 18:03 potatosenior

@tbleckert, this would be lovely to merge in 😌

and-poulsen avatar Mar 02 '23 16:03 and-poulsen