Tom Birdsong

Results 119 comments of Tom Birdsong

Having a better understanding now of how FFT factory registration is intended to work, I'm not sure that we actually need `ITKUltrasound` to depend on `ITKVkFFTBackend`. The goal of how...

That would help reduce dependencies. One caveat on this issue is that we can't provide GPU-accelerated FFTs for curvilinear ultrasound images without one module having knowledge of the other. We...

After bumping to 0.5.4 for factory initializations, notebook check now fails with resampleimagefilter failure ``` TemplateTypeError: itk.ResampleImageFilter is not wrapped for input type `itk.CurvilinearArraySpecialCoordinatesImage[itk.F,2], itk.Image[itk.F,2]`. ``` Related to the workaround...

With recent fixes notebooks are now passing again 🟢 It is not practical to build Python packages every time we want to check notebooks, and whether Python packages pass/fail should...

Note that the ITK reusable workflow [build-test-package-python](https://github.com/InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#build-test-package-python-overview) supports notebook testing with build artifacts. Suggest removing the dedicated `test-notebook.yml` file in favor of `with: test-notebooks: true` in that workflow.

To that point, we already host/include liver spectra samples for attenuation testing (see [data.kitware.com](https://data.kitware.com/#collection/57b5c9e58d777f126827f5a1/folder/6218eff24acac99f425cf6a3)). @dzenanz should I amend this issue to reflect adding `Spectra1DAveragingImageFilter` and `Spectra1DNormalizeImageFilter` tests on sample data?...

@dzenanz I've added #189 as a sanity check applying averaging and normalization separately to practical data. I agree that the workflow you've suggested here would make a good integration test,...

Separated out some `BlockMatching` wrappings into individual files and added `itkBlockMatchingBayesianRegularizationDisplacementCalculator.wrap`.

Wrapping succeeds and `MultiResolutionImageRegistrationMethod` Python example passes, but seeing a new CTest error: > 28/33 Test #28: itkBlockMatchingBayesianRegularizationDisplacementCalculatorTest ......................***Exception: SegFault 7.91 sec Debugging locally, the error happens here in `itkBlockMatchingBayesianRegularizationDisplacementCalculator.hxx`:...

Agreed, this is an issue with backwards compatibility between current PyPI wheels for this project and ITK v5.3.0. Short-term workaround: uninstall all ITK modules before install ITK v5.3rc3 wheels ```...