cutde icon indicating copy to clipboard operation
cutde copied to clipboard

number precission issue half-space vertically oriented TDE

Open hvasbath opened this issue 5 months ago • 2 comments

Hi again Ben,

seems like doing source inversion you find the instabilities in the code as the sampler finds the singularities haha. Comparing to matlab I pinned down the issue to num.float32 vs num.float64. For a TDE that is vertically oriented in half-space number precission for GPU of float32 produces instable results.

Just want to report here, I could make a PR with a test-if you deem it useful. I was discussing with Mehdi Nikhoo and we identified the problem to be in this line of the code/equatins: https://github.com/tbenthompson/cutde/blob/master/cutde/common.cu#L527

This exists also in the matlab code. He mentions this goes back to typos in the equations of AngularDislocations and it would require quite some effort to rederive them to find the typo. So likely no easy fix for that one...

Hannes

hvasbath avatar Mar 01 '24 14:03 hvasbath