Tal Ben-Nun
Tal Ben-Nun
All comments addressed in #2071. The work on this PR is superseded by and cherry-picked into that PR.
Excellent PR, thank you for doing it! Please add a comment in #2036 to mention that TB maps need to be added as a pass. Also, I would use the...
Sounds good, why are some tests failing?
> @tbennun The only tests that are failing are expected to fail (FV3): > > > Note: The FV3 integration test fails and will continue to fail with this PR,...
For most cases, it’s important to preserve the copies. For other cases, this is why we have permissive=True
As a note, #1696 does not close this issue, but takes care of half of it. The other half is to consolidate descriptor repositories (symbols, data containers, etc.)
This should not be the correct behavior. Eliminating an access node that corresponds to a data container has to be done safely: if a data container is used in another...
@philip-paul-mueller related to what you are working on?
@copilot CI still fails. Can you please fix the remaining errors? Here is an example: `FAILED tests/codegen/nested_kernel_transient_test.py::test_nested_kernel_transient - NotImplementedError: GPU global memory to global memory copies need to be more...