ng2-nouislider icon indicating copy to clipboard operation
ng2-nouislider copied to clipboard

feat: upgrade to angular 8 and cli

Open mattlewis92 opened this issue 6 years ago • 10 comments

Migrates to the latest angular version and uses the CLI to do all the build tooling.

BREAKING CHANGE: angular 8 or higher is now required to use this library

This should enable full compatibility with ivy, currently it fails with:

ERROR in node_modules/ng2-nouislider/ng2-nouislider.module.d.ts(1,22): error TS-996002: Appears in the NgModule.imports of TestModule, but could not be resolved to an NgModule class

because of the older build tooling.

I'm also thinking it would be a good time to rename the package to ngx-nouislider, I've reached out to the person who currently has the package name to try and get access.

Try it today with:

npm i ng2-nouislider@next

mattlewis92 avatar Jun 01 '19 19:06 mattlewis92

Great work @mattlewis92 with ivy compatibility!

PR is now only dependant on the npm package name change.

tb avatar Jun 03 '19 07:06 tb

Nice work! When this would be merged?

meness avatar Jun 07 '19 10:06 meness

@meness I'm just waiting on getting the new package name. but you can try it today with:

npm i ng2-nouislider@next

mattlewis92 avatar Jun 07 '19 12:06 mattlewis92

Thanks @mattlewis92 I will be using @next now, any update on the package rename?

alejandrocoding avatar Jun 26 '19 11:06 alejandrocoding

No update yet, I've pinged the maintainer again for an update, but if I don't hear anything back then I'll just release this on the existing package name and maybe in the future we can rename to something else.

mattlewis92 avatar Jun 26 '19 11:06 mattlewis92

anything new with the maintainer? when will this will be official ? @tb Tomasz Bak

LiorSaadon avatar Aug 21 '19 14:08 LiorSaadon

Nope I didn't hear anything back, I'll just release it under the original package name for now, we can always move it over later in another release.

FYI there's no real urgency for this now, as the ivy compat issues have been fixed on the angular side, so the only change will just be requiring angular 8 or above

mattlewis92 avatar Aug 21 '19 15:08 mattlewis92

any news? this project seems to be absolutely dead.

Carlesgg97 avatar Aug 28 '20 20:08 Carlesgg97

hey, @mattlewis92 with angular 13, I would be willing to update this project to v13 maybe - to go with angular versioning schema and go with full compilation maybe or at least partial but in new lib format of Angular 13 to get rid of ngcc compilation on this lib?

From Angular 13:

Processing legacy "View Engine" libraries: Encourage the library authors to publish an Ivy distribution.

kbrilla avatar Nov 26 '21 10:11 kbrilla

hey, @mattlewis92 with angular 13, I would be willing to update this project to v13 maybe - to go with angular versioning schema and go with full compilation maybe or at least partial but in new lib format of Angular 13 to get rid of ngcc compilation on this lib?

That sounds great, yes please! Not sure if it's easiest to branch off this PR and upgrade with ng update for each major version, or just start with a fresh angular CLI library and copy the files over.

mattlewis92 avatar Nov 26 '21 11:11 mattlewis92

Closing in favor of https://github.com/tb/ng2-nouislider/pull/241 (this was finally released to npm as 2.0.0 stable!!)

mattlewis92 avatar Jun 07 '23 15:06 mattlewis92