nixery icon indicating copy to clipboard operation
nixery copied to clipboard

feat(pop): generate popularity on startup if url is not set

Open maxhbr opened this issue 4 years ago • 5 comments

maxhbr avatar Mar 19 '21 15:03 maxhbr

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 19 '21 15:03 google-cla[bot]

Oh, you require a CLA,..

maxhbr avatar Mar 19 '21 15:03 maxhbr

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 19 '21 15:03 google-cla[bot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 19 '21 15:03 google-cla[bot]

Thanks, this is a good idea! Two thoughts:

  • I wonder if this should be on by default. Fetching all the required metadata is quite heavy, so it might be useful to make it opt-in instead.

  • nixery-popcount is also a Go program, maybe its code should be used as a library instead in this use-case?

tazjin avatar Mar 19 '21 21:03 tazjin