tazend

Results 53 comments of tazend

@giovtorres Sounds good! Yeah it doesn't seem like I have permissions to add things there. Would be nice if you can grant me access if possible.

Unfortunately still read-only for me there.

> > Unfortunately still read-only for me there. > > Try now? 🙏🏼 Unfortunately still can't add there.

Hi @JonaOtto thanks for the addition. I think instead of merging into the 21.08 branch, it would be better to directly merge into `main`. After that, I can simply backport...

Hi @JonaOtto just had another look at it. I think there might be a little problem with the logic though. The problem is that the only condition tested for here...

Hi @JonaOtto Except for the one thing I mentioned with the potential memory-leak which needs to be fixed, everything else looks good. Additionally I'd like to have this directly into...

Hi @JonaOtto I mentioned the memory leak [in line 2921](https://github.com/PySlurm/pyslurm/pull/242/files#diff-6b6a59c3c7910749cc02b910df1c274f157d16a3dfab92fc63d9e14bf9d65c4fR2921) (I hope my comment shows up there as review?) Yes, after [line 2934](https://github.com/PySlurm/pyslurm/pull/242/files#diff-6b6a59c3c7910749cc02b910df1c274f157d16a3dfab92fc63d9e14bf9d65c4fR2934) - still within the while loop, but...

@JonaOtto alright, everything looks good! Yeah it was my fault, I added the comment but didn't actually submit the review so it wouldn't show up for you. Anyway, we can...

Hi, this is likely due to a missing call to the `slurm_init()` function. In Slurm 20.11 they introduced this in the C-API, and a call to this function is required...

Hi @Whitehorse2 I have backported the necessary functions. If you want, you can test it with [this branch here]( https://github.com/PySlurm/pyslurm/tree/slurm-20.11.8) This Branch also includes a few more commits that came...