Taylor Vann

Results 62 comments of Taylor Vann
trafficstars

This issue should be resolved with #3072 :) curious if that can be confirmed

I find this part pretty interesting: ```TS export declare type CustomElementWithEvents< ComponentClass, CustomEventName extends string > = HTMLAttributes & Omit & { ref?: MutableRefObject; } & Partial; ``` We already...

A type that does not include event listeners would be a good place to start. That is the main difference between React handling web components and LitLabs React Wrapper handling...

@michaelwarren1106 totally agree and that's actually our goal code-wise! It's nice to see a similar conclusion independent of ours :)

@michaelwarren1106 an explicitly exported type `ReactWebComponent` is now exported from `@lit-labs/react`! We're halfway to the type you requested! I believe one of the following types would be what you needed...

ah gen-wrapper-react needs to be updated

Coming back to this, I still think a params object is a good idea for future-proofing the library. Caveat is, we're gonna need to define what we are returning in...

@justinfagnani will def try! Dunno why I got stuck on a 1:1 typing. You're correct that should work!

This PR might be resolved with #3072 :) curious if that can be confirmed