taxjar-php
taxjar-php copied to clipboard
taxjar
Adjust PHPDoc for transaction identifiers
This PR will adjust PHPDoc as according to the docs the transaction ID may be a string: The transaction_id should only include alphanumeric characters, underscores, and dashes.
Currently it is typehinted as integer and it is triggered as an issue in some linters.
@VladimirBerdnik First, my apologies that it has taken so long for someone to address this pull request. I realize this ask represents additional work on your behalf since you've closed this PR, but if you'd be willing to re-open, we would like to address this PHPDoc type issue and I'd like you to be credited for your contribution.
@sethobey , thank you for the :heavy_check_mark: ! Do you think you could merge the PR and release a new version?
@VladimirBerdnik It appears that since Travis CI migrated sometime in the last year, the continuous-integration/travis-ci check has been unable to receive success webhooks, blocking our ability to merge based on repository settings.
For security, only certain individuals have access to particular repo settings, so I've reached out for assistance and am awaiting a response. Not to worry though, this contribution along with other updates will soon be included in a new taxjar-php release 👍