asciinema2gif icon indicating copy to clipboard operation
asciinema2gif copied to clipboard

Published 20 hours ago • verified publisher icon tav

Refactor render.js

Open wong2 opened this issue 8 years ago • 4 comments

it's hard to maintain

wong2 avatar Oct 09 '16 03:10 wong2

It is only 170 lines. What is so hard there?

techtonik avatar Oct 09 '16 12:10 techtonik

@techtonik the problem is that it's basically spaghetti code with many callbacks

wong2 avatar Oct 10 '16 06:10 wong2

Apart from repeated includeJQuery(init, function() { I don't see much spaghetti there. It looks like PhantomJS just doesn't synchronous style like CasperJS.

techtonik avatar Oct 10 '16 06:10 techtonik

@techtonik yeah it's JavaScript itself

wong2 avatar Oct 11 '16 03:10 wong2