webkit2gtk-rs icon indicating copy to clipboard operation
webkit2gtk-rs copied to clipboard

Update repository URLs for dependencies

Open ghost opened this issue 4 years ago • 4 comments

Build aborts with 525 errors, but at least all dependencies are retrieved now!

ghost avatar Jun 20 '21 22:06 ghost

I've tried regenerating the bindings, and I'm not sure if I'm doing it right, but whatever I'm doing isn't fixing the build errors?

I've run make gir in the root directory, which seems to be regenerating the bindings, and then running cargo fmt on them. This produces no difference with the current contents of src/auto in master.


EDIT: Never mind, I figured it out. I had to update the gir and gir-files submodules. Adding regenerated bindings in a new commit to this PR.

ghost avatar Jun 20 '21 22:06 ghost

It appears that the three remaining build errors are due to the fact that glib::translate::ToGlib no longer exists?


Ah, it appears it's now called into_glib. I've manually changed that, and now I'm getting 13 errors because gtk::{ContainerExt, WidgetExt} and webkit2gtk::{SettingsExt, WebContextExt, WebViewExt} cannot be found.

ghost avatar Jun 20 '21 22:06 ghost

Hopefully I'm helping in some manner? While I don't think I can progress further on my own as I'm unfamiliar with the inner workings of the GTK-rs project, I do think I've laid the groundwork for someone else to pick up where I left off

ghost avatar Jun 20 '21 23:06 ghost

I believe I'm pretty much done, as of my latest commit? I'm seeking outside review and tweaks, and hopefully this PR will get merged. Build errors have been resolved, and closes: #93.

ghost avatar Jul 15 '21 20:07 ghost