tauri icon indicating copy to clipboard operation
tauri copied to clipboard

chore(deps): migrate dirs_next to dirs

Open Legend-Master opened this issue 1 year ago • 1 comments

Reference: https://github.com/tauri-apps/tauri/issues/6063

Legend-Master avatar May 31 '24 05:05 Legend-Master

I'm not familiar with the changes dirs made in version 3 and 4 (config_dir is changed on Mac, executable_dir $XDG_DATA_HOME changed on Linux), need some help on those 2

Legend-Master avatar May 31 '24 06:05 Legend-Master

config_dir is changed on Mac

Looking at https://docs.rs/dirs-next/latest/dirs_next/fn.config_dir.html vs https://docs.rs/dirs/latest/dirs/fn.config_dir.html, they look the same, no?

executable_dir $XDG_DATA_HOME changed on Linux

Same, https://docs.rs/dirs-next/latest/dirs_next/fn.executable_dir.html vs https://docs.rs/dirs/latest/dirs/fn.executable_dir.html.

Am I missing something obvious here?

amrbashir avatar Jun 03 '24 19:06 amrbashir

Ah, never mind the mac one, it's already changed to this directory in dirs-next 2.0, it's a breaking change in dirs 3.0, didn't look too closely at the time

About the linux one, I just don't know what does this mean, maybe there's nothing to be worried about

BREAKING CHANGE The behavior of executable_dir has been adjusted to not depend on $XDG_DATA_HOME. Code, which assumed that setting the $XDG_DATA_HOME environment variable also impacted executable_dir if the $XDG_BIN_HOME environment variable was not set, requires adjustment.

Legend-Master avatar Jun 04 '24 01:06 Legend-Master