tauri icon indicating copy to clipboard operation
tauri copied to clipboard

Support sending raw byte data to the "data" event for child command's stdout and stderr

Open cymruu opened this issue 3 years ago • 5 comments

What kind of change does this PR introduce?

Support sending raw byte data to the "data" event for child command's stdout and stderr. Still WIP

  • [ ] Bugfix
  • [x] Feature
  • [ ] Docs
  • [ ] New Binding issue #___
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change?

  • [x] Yes, and the changes were approved in issue #5465
  • [ ] No

Checklist

  • [ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • [ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • [ ] I have added a convincing reason for adding this feature, if necessary

Other information

Closes #5465

cymruu avatar Dec 08 '22 22:12 cymruu

@amrbashir I have addressed your comments. Thank you for reviewing!

cymruu avatar Dec 12 '22 21:12 cymruu

Looks really good. I'll make some tests and see if we can improve the api types.

lucasfernog avatar Dec 13 '22 17:12 lucasfernog

Let me know what you think about my change :P I'm not a TypeScript expert but I tried to let it infer most of the types from the encoding argument.

lucasfernog avatar Dec 13 '22 18:12 lucasfernog

@lucasfernog thank you for the improvement with result type inferring. I love it! I have merged with nextbranch again.

BTW what is the reason behind bundle.global.js being included in the repository?

cymruu avatar Dec 19 '22 09:12 cymruu

bundle.global.js powers the withGlobalTauri (= the apis in window.__TAURI__). Building/Bundling that on the dev's machine is not really an option

FabianLars avatar Dec 19 '22 09:12 FabianLars

@lucasfernog @FabianLars Is the feature still needed? Is there anything else I can do regarding the PR? I'm happy to help 🙂

cymruu avatar Feb 08 '23 21:02 cymruu

I just need some time to test this, my idea was to wait for 1.3 to launch before merging it since you already merged dev into this.

lucasfernog avatar Feb 09 '23 15:02 lucasfernog

Amazing work!

lucasfernog avatar Mar 31 '23 15:03 lucasfernog