Support sending raw byte data to the "data" event for child command's stdout and stderr
What kind of change does this PR introduce?
Support sending raw byte data to the "data" event for child command's stdout and stderr. Still WIP
- [ ] Bugfix
- [x] Feature
- [ ] Docs
- [ ] New Binding issue #___
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:
Does this PR introduce a breaking change?
- [x] Yes, and the changes were approved in issue #5465
- [ ] No
Checklist
- [ ] When resolving issues, they are referenced in the PR's title (e.g
fix: remove a typo, closes #___, #___) - [ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
- [ ] I have added a convincing reason for adding this feature, if necessary
Other information
Closes #5465
@amrbashir I have addressed your comments. Thank you for reviewing!
Looks really good. I'll make some tests and see if we can improve the api types.
Let me know what you think about my change :P I'm not a TypeScript expert but I tried to let it infer most of the types from the encoding argument.
@lucasfernog thank you for the improvement with result type inferring. I love it! I have merged with nextbranch again.
BTW what is the reason behind bundle.global.js being included in the repository?
bundle.global.js powers the withGlobalTauri (= the apis in window.__TAURI__). Building/Bundling that on the dev's machine is not really an option
@lucasfernog @FabianLars Is the feature still needed? Is there anything else I can do regarding the PR? I'm happy to help 🙂
I just need some time to test this, my idea was to wait for 1.3 to launch before merging it since you already merged dev into this.
Amazing work!