tauri icon indicating copy to clipboard operation
tauri copied to clipboard

None empty

Open sftse opened this issue 3 weeks ago • 4 comments

Noticed a code pattern where None is used in place of an empty vector. The resulting code has to transform between different representations and liberally uses get_or_insert on the None. This is a bit roundabout, so use empty Vec as a replacement for None.

Empty Vecs don't allocate, so this changes nothing except make the code shorter.

Not entirely sure, but also think this fixes a bug where the code paths of None and Some(Vec::new()) would have diverged.

sftse avatar Dec 04 '25 13:12 sftse

Package Changes Through e6623eaf1a97fcf532581a5c95a1d86fc69b5d82

There are 4 changes which include tauri-macos-sign with patch, @tauri-apps/cli with patch, tauri-cli with patch, tauri-bundler with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-macos-sign 2.3.1 2.3.2
tauri-bundler 2.7.4 2.7.5
@tauri-apps/cli 2.9.5 2.9.6
tauri-cli 2.9.5 2.9.6

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

github-actions[bot] avatar Dec 04 '25 15:12 github-actions[bot]

@FabianLars Fixed CI

sftse avatar Dec 05 '25 10:12 sftse

I'm a bit confused by how the change sets work, the bot suggested

---
"@tauri-apps/api": patch
"tauri-utils": patch
"tauri-macos-sign": patch
"tauri-bundler": patch
"tauri-runtime": patch
"tauri-runtime-wry": patch
"tauri-codegen": patch
"tauri-macros": patch
"tauri-plugin": patch
"tauri-build": patch
"tauri": patch
"@tauri-apps/cli": patch
"tauri-cli": patch
"tauri-driver": patch
---

even though only tauri-cli has any changes. Is this correct?

sftse avatar Dec 05 '25 10:12 sftse

no the bot just lists all existing packages. just remove all that you didn't touch (eg in your case only tauri-cli needs to be there)

FabianLars avatar Dec 05 '25 18:12 FabianLars