tauri icon indicating copy to clipboard operation
tauri copied to clipboard

feat: add option to not wait on notarization to finish

Open FabianLars opened this issue 7 months ago • 5 comments

The first time you try to notarize an app can take multiple hours (apparently even days), very easily hitting the timeout of github actions (and consuming insane amounts of build minutes in private repos).

This PR offers a simple flag to opt out of the waiting mechanic with the drawback of not being able to staple the notarization ticket onto the app automatically.

In the future we probably should look into a timeout mechanic instead but this is more of a hotfix.

Note that i did not test this.

FabianLars avatar May 28 '25 12:05 FabianLars

With Note that i did not test this. i meant actual signing/notarizing not building the CLI 😭 ~~what did i doooo~~ ah it's the tests

FabianLars avatar May 28 '25 13:05 FabianLars

since this is supposed to be a temporary measure i don't think it should be done in the config file; maybe a CLI option would be better? i feel like most people wouldn't use it anyway until they hit this particular problem, which is too late anyway...

lucasfernog avatar May 28 '25 18:05 lucasfernog

i wanted to add it as a cli flag at first but it also felt kinda weird idk (actually just couldn't think of an arg name...). will change it tomorrow-ish

also, i think we should even add this to our signing guide as a recommendation for the first notarization.

FabianLars avatar May 28 '25 20:05 FabianLars

Package Changes Through 631de2e348ddda7bef9d1e41ef60ecac3dadecac

There are 9 changes which include tauri-cli with minor, @tauri-apps/cli with minor, tauri-utils with minor, tauri-bundler with minor, tauri-macos-sign with minor, tauri-runtime-wry with patch, tauri with minor, @tauri-apps/api with minor, tauri-plugin with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.7.0 2.8.0
tauri-utils 2.6.0 2.7.0
tauri-macos-sign 2.1.0 2.2.0
tauri-bundler 2.5.2 2.6.0
tauri-runtime 2.7.1 2.7.2
tauri-runtime-wry 2.7.2 2.7.3
tauri-codegen 2.3.1 2.3.2
tauri-macros 2.3.2 2.3.3
tauri-plugin 2.3.1 2.4.0
tauri-build 2.3.1 2.3.2
tauri 2.7.0 2.8.0
@tauri-apps/cli 2.7.1 2.8.0
tauri-cli 2.7.1 2.8.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

github-actions[bot] avatar May 31 '25 11:05 github-actions[bot]

still not tested (no notarization setup) and the changes also felt weird. was a bit more work than expected for a simple cli arg

FabianLars avatar May 31 '25 12:05 FabianLars