tauri-docs icon indicating copy to clipboard operation
tauri-docs copied to clipboard

feat: added a splashscreen lab

Open simonhyll opened this issue 2 years ago • 2 comments

What kind of changes does this PR include?

  • New or updated content

Description

Adds a new splashscreen lab.

simonhyll avatar May 01 '24 21:05 simonhyll

Deploy Preview for tauri-v2 ready!

Built without sensitive environment variables

Name Link
Latest commit a642db22b93e0f3b2db04595b6c47de93b0d68ca
Latest deploy log https://app.netlify.com/sites/tauri-v2/deploys/66620f943ab1fe0007005e25
Deploy Preview https://deploy-preview-2106--tauri-v2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 01 '24 21:05 netlify[bot]

It's not perfect yet but it's close enough now where I'd like some input on it. 😄

simonhyll avatar May 21 '24 16:05 simonhyll

I'm just looking at it right now lol, good timing

vasfvitor avatar May 23 '24 17:05 vasfvitor

what do you think of adding the full CLI as a way to quick start? I guess it should be

pnpm create tauri-app --beta --template vanilla --manager pnpm --mobile yes splashscreen-lab

vasfvitor avatar May 23 '24 17:05 vasfvitor

I'm gonna follow the lab and give my feedback based on it

vasfvitor avatar May 23 '24 17:05 vasfvitor

what do you think of adding the full CLI as a way to quick start? I guess it should be

pnpm create tauri-app --beta --template vanilla --manager pnpm --mobile yes splashscreen-lab

@vasfvitor The main reason I didn't do that was because it's very convenient to just add the CTA fragment we have to things and keep that as the main for everyone. Giving the full command feels less real-world adapted, the lab aims to provide some practical experience after all, might as well make people use the method they'd use the most in the future right? And if we do a full command we'd need to provide it for all package managers.

simonhyll avatar Jun 06 '24 13:06 simonhyll

well, even after the requested changed it doesn't work. Tried to fix it, broke even more. I could give another shot, or do you want to do it yourself?

Is the goal to teach about state? Because if not, I think, if possible, it should be done without it. Or else, add a requirement lab that teaches about managing state. Speaking of which, I've read many times your webpage about state and it helped me A LOT when I needed it , really!

Glad to head the article is of use to people ❤️

It's not explicitly the intent to teach about states but I also have a hard time seeing how to tackle this without states, or rather I have a hard time seeing a more appropriate solution to this specific use-case. We can definitely add a reference link to where people can read up more on states, not sure I'd say it's a prerequisite necessarily, I think I can include a very short text on what states are in the lab and it'll be good enough for the sort of copy-paste nature of labs

simonhyll avatar Jun 06 '24 13:06 simonhyll

@vasfvitor Yea it can be improved upon, especially considering right now I haven't touched upon how to do the splashscreen for mobile devices, but it's a start 🙂 We'll merge it and then get followup PR's for improving it

simonhyll avatar Jun 06 '24 19:06 simonhyll