tao icon indicating copy to clipboard operation
tao copied to clipboard

Published 20 hours ago • verified publisher icon tauri-apps

Add DeviceEventFilter on Windows

Open wusyong opened this issue 3 years ago • 5 comments

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Docs
  • [ ] New Binding issue #___
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change?

  • [ ] Yes, and the changes were approved in issue #___
  • [x] No

Checklist

  • [ ] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • [ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • [ ] I have added a convincing reason for adding this feature, if necessary

Other information

wusyong avatar Jul 06 '22 06:07 wusyong

winit just merged the device event filter for windows, https://github.com/rust-windowing/winit/pull/2409

amrbashir avatar Aug 11 '22 14:08 amrbashir

Not sure that merely qualifying on win10 (winit's PR) is good enough, ngl: image

nothingismagick avatar Aug 11 '22 14:08 nothingismagick

That's the just the PR author testing, it should work fine for >=win7, I checked the MSDN docs for the used apis and they are all supported for win xp and newer (except one flag which was added in win vista)

amrbashir avatar Aug 11 '22 15:08 amrbashir

winit just merged the device event filter for windows, rust-windowing/winit#2409

I'm a little busy on mobile support at the moment. I can resume this work once it's done. Or anyone is interested can take it too.

wusyong avatar Aug 12 '22 07:08 wusyong

I can take this

amrbashir avatar Aug 12 '22 14:08 amrbashir

@amrbashir I rebased the PR to resolve merge conflict. Might need your approve since this is my PR.

wusyong avatar Aug 17 '22 08:08 wusyong