tao icon indicating copy to clipboard operation
tao copied to clipboard

Changed to activate before opening window on macos.

Open islandryu opened this issue 2 years ago • 2 comments

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Docs
  • [ ] New Binding issue #___
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Build-related changes
  • [ ] Other, please describe:

Does this PR introduce a breaking change?

  • [ ] Yes, and the changes were approved in issue #___
  • [x] No

Checklist

  • [x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • [x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • [x] I have added a convincing reason for adding this feature, if necessary

Other information

fix https://github.com/tauri-apps/tauri/issues/4310

Fixed a bug that when starting tao with cargo run on macos, it was activated after the window was opened.

before fixed

https://user-images.githubusercontent.com/65934663/175223299-9a5e9107-59e8-4220-8546-962b9bc96289.mov

after fixed

https://user-images.githubusercontent.com/65934663/175223480-0aaee509-2cd1-4170-8f11-1980b840be3b.mov

islandryu avatar Jun 23 '22 05:06 islandryu

Hey folks!

What is the status here? Is there a chance to get this into main soon?

Best, Adrian

Hupka avatar Aug 25 '22 07:08 Hupka

@amrbashir @keiya01 @wusyong Apologies for the pings -- are there any updates on the review of this PR?

stephenlrandall avatar Sep 08 '22 14:09 stephenlrandall