tao
tao copied to clipboard
fix: #268 - Add API for MacOS NSWindow::isDocumentEdited()
What kind of change does this PR introduce?
This fixes tauri-apps/tao#268 and therefore tauri-apps/tauri#3125
- [ ] Bugfix
- [ ] Feature
- [ ] Docs
- [x] New Binding issue #268
- [ ] Code style update
- [ ] Refactor
- [ ] Build-related changes
- [ ] Other, please describe:
Does this PR introduce a breaking change?
- [ ] Yes, and the changes were approved in issue #___
- [x] No
Checklist
- [x] When resolving issues, they are referenced in the PR's title (e.g
fix #___, #___
) - [ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
- [x] I have added a convincing reason for adding this feature, if necessary
Other information
The setter API is added upstream in the cocoa crate (servo/core-foundation-rs PR #493)), which will need to be merged & released before this PR.
Thanks for contribution. It seems the PR you linked, just got merged, I guess we need to wait for release only.
Done. I'm not clear on the difference between Window
& UnownedWindow
(in terms of usage), but everything builds & tests the same.
This PR needs to wait for a new release of cocoa
crate
lol the PR is so old, it was targeting next
and I didn't notice so I had to cherry pick it into dev
and reset next