Feature/fallback targets

[kandrelczyk]

Here are the changes for updater to handle #2277

I'm using the patched __TAURI_BUNDLE_TYPE variable to download the proper installer with fallback as described in #2277.

I've added some additional test on both Linux and Windows. Not sure if something needs to be done on other platforms.

[github-actions[bot]]

Package Changes Through abcee1f72a50e620cc0d25f2aba04c416831790d

There are 2 changes which include updater with minor, updater-js with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package	current	next
api-example	2.0.35	2.0.36
api-example-js	2.0.31	2.0.32
updater	2.9.0	2.10.0
updater-js	2.9.0	2.10.0

Add another change file through the GitHub UI by following this link.

---

Read about change files or the docs at github.com/jbolda/covector

[kandrelczyk]

Windows and Linux tests are failing because they require tauri-cli with https://github.com/tauri-apps/tauri/pull/13209 change.

MacOS test is failing because of some compliation issue. I will have access to a mac next week so I will fix it.

[FabianLars]

MacOS test is failing because of some compliation issue. I will have access to a mac next week so I will fix it.

It looks like you ran cargo update - if you revert the Cargo.lock file changes it should compile again.

[kandrelczyk]

Ok, I've updated tauri version for updater plugin to 2.7 and the tests now pass with latest tauri-cli. Anything missing here?

[kandrelczyk]

@beanow-at-crabnebula I've addressed the comments. Please take a look and let me know if anything else needs fixing.

[Legend-Master]

Honestly, I feel like the entire target thing is a bit confusing, tauri_plugin_updater::target returns {os}-{arch} while we replace {{target}} inside the URL with just the OS, also with the introduction of installer to the mix, this gets even more confusing, should tauri_plugin_updater::target return with the installer info or not?

Also feel like we should probably remove the json_target field in Updater and handle this logic in check instead

[kandrelczyk]

@Legend-Master moved the logic to check.

[kandrelczyk]

Added change file.

And thank you. This should go way smoother but I'm hitting a lot of Rust related things that are new to me.

BTW what about latest.json file? Generating latest.json with new version of target is something we still have to do, right? Is that part of github actions?

[Legend-Master]

And thank you. This should go way smoother but I'm hitting a lot of Rust related things that are new to me.

No worries, we all came from there 🙃

BTW what about latest.json file? Generating latest.json with new version of target is something we still have to do, right? Is that part of github actions?

Yeah, that's either made by the user (we need to update the docs after this) or through https://github.com/tauri-apps/tauri-action, and in that case, we need to give it an update as well

[FabianLars]

Maybe you guys want to also give it a review in case I missed something 🙃 (especially about the dynamic server part since I didn't quite follow the discussions about that part)

give me a day or two.

also don't worry about tauri-action (unless you want to of course)

[kandrelczyk]

Addressed the comments.

[FabianLars]

Addressed the comments.

Not all of them yet :) In case it's github's UI being weird again, here are the ones i saw: https://github.com/tauri-apps/plugins-workspace/pull/2624#discussion_r2235237479 https://github.com/tauri-apps/plugins-workspace/pull/2624#discussion_r2234117536 https://github.com/tauri-apps/plugins-workspace/pull/2624#discussion_r2234118038 https://github.com/tauri-apps/plugins-workspace/pull/2624#discussion_r2259881222 https://github.com/tauri-apps/plugins-workspace/pull/2624#discussion_r2235218319

[kandrelczyk]

@FabianLars checked all the comments again. Some of them I would rather leave for another PR (better to finally merge this and keep working in a clean branch). I moved the bundle type to a pure function. The only unaddressed comment is the one about mixed up responsibilities but I don't know what specifically should be changed there. Any ideas?

[lucasfernog]

I think we can release this one next week

[Legend-Master]

I have reverted the tauri bumps to align with the main branch, and since we have already bumped the workspace tauri requirement to 2.8 in main branch, we can remove the separate bump in the updater plugin now

[FabianLars]

after merging this, please wait with the release until we support the {{}} url thingy too :) i feel like it doesn't make sense to not release them together.

[kandrelczyk]

@FabianLars can please explain what needs to be done for the {{}}? Is it for the dynamic URL? What exactly is missing and how it should work?

I will also take a look at latest.json generation.

[FabianLars]

it's for the dynamic urls, yes and i'm pretty sure that it would require really just https://github.com/tauri-apps/plugins-workspace/pull/2624#discussion_r2234117536 and https://github.com/tauri-apps/plugins-workspace/pull/2624#discussion_r2234118038

edit: nevermind, with some of the changes since then those suggestions don't work as-is anymore but the gist is the same.

[kandrelczyk]

Ok, I'm happy to do it. I can work on it this week.

[FabianLars]

went ahead and opened https://github.com/tauri-apps/plugins-workspace/pull/2960 sorry 😅 wanted to get to testing asap