plugins-workspace icon indicating copy to clipboard operation
plugins-workspace copied to clipboard

[shell] Add option to spawn command in process group

Open FabianLars opened this issue 1 year ago • 4 comments

this is basically the fix to issues like pyinstaller apps not being killed because pyinstaller wraps the actual app in a thin parent process that doesn't clean up after itself.

v1's command code was a bit too much for me to find motivation tbh but in this plugin it should be fairly straight forward.

Since may be use cases where this is not desirable, it will be a simple boolean option.

The implementation should use https://github.com/watchexec/process-wrap, the successor of command-group.

p.s. just opening this issue so i don't forget about it until next week, not asking the team to work on this (however, if a community member wants to work on this then i'd be quite happy about it)

FabianLars avatar May 16 '24 19:05 FabianLars

Hi, is this in progress?

mitulagr2 avatar Jul 13 '25 07:07 mitulagr2

No. I started it a few weeks/months ago but it was more annoying to implement than expected. Not even sure if I still have the local branch, gonna check on Monday.

If you're asking cause you want to pick it up then go for it :)

FabianLars avatar Jul 13 '25 07:07 FabianLars

Is there any API stub? I don't need this feature anymore since I came up with my own solution to the problem but if I ever get the time I'd be happy to help since it makes my code redundant.

Like just add an option to spawn in a group basically?

elibroftw avatar Oct 26 '25 01:10 elibroftw

Like just add an option to spawn in a group basically?

That was the idea, yeah. Perhaps not realistic though. I think I lost the very-wip branch I worked on a few months ago though, will check later.

FabianLars avatar Oct 26 '25 08:10 FabianLars