SwipeTransition icon indicating copy to clipboard operation
SwipeTransition copied to clipboard

Swift Package Manager support

Open AndrewSB opened this issue 3 years ago • 5 comments

This doesn't work perfectly - it looks like the Automation target has an error when running swift build.

It works for the SwipeTransition framework though, and has made it so I can target my branch as a dependency in my app. I might look to fix this in a few weeks, but if someone else would like to commandeer this and finish what I started, please feel free!

AndrewSB avatar Sep 30 '20 22:09 AndrewSB

Thank you for your contribution! It's a nice feature 👍

I'll merge it after trying it.

tattn avatar Oct 01 '20 13:10 tattn

@AndrewSB it may be broken with Carthage build.

% carthage update
*** Checking out SwipeTransition at "0452b7929e128631e856dce2db0780422bacd008"
*** xcodebuild output can be found in /var/folders/z3/lyh75tws0hg4nsp2wrg6gxnw0000gq/T/carthage-xcodebuild.cv7MVo.log
*** Building scheme "SwipeTransition" in SwipeTransition.xcodeproj
Build Failed
        Task failed with exit code 65:

Could you fix the problem?

tattn avatar Oct 01 '20 14:10 tattn

just rebased all the changes on master.

2 issues with this PR:

  1. breaks Carthage support. this isn't something i'm going to prioritize fixing, i'm happy to continue using my branch
  2. It has a single "Automation" product that isn't exposed, instead of having AutoSwipeBack and AutoSwipeToDismiss as 2 targets that can be pulled in. since I'm only using the SwipeBack framework, i haven't taken the time to separate them out

I'm happy to accept anyone else's work on top of this to enable that, i'll try to keep my branch upto date 😄

AndrewSB avatar Sep 06 '22 23:09 AndrewSB

Hi @tattn Any update on the above PR ? are you merging it we would like to have spm version

karthiikmk avatar Jun 22 '23 06:06 karthiikmk

Sorry for my late reply.

I think this implementation is good and I now believe that Carthage support is unnecessary.

Therefore, I'd like to merge this PR, but I can't merge it into main branch until updating README.md and some code.

So I create swiftpm branch and I'll merge this PR into it after resolving conflicts. I'd like to fix it if I have time, but would welcome PRs from anyone.

tattn avatar Jun 23 '23 14:06 tattn