CalendarBundle icon indicating copy to clipboard operation
CalendarBundle copied to clipboard

Timezone support

Open freezy-sk opened this issue 4 years ago • 11 comments

Timezone param is sent when timezone is specified, but it was not passed to calendar event. Datetimes returned from event entity were formatted as in UTC timezone, but actually they were just losing their offset. That's all fixed with this pull request, following FullCalendar docs https://fullcalendar.io/docs/timeZone

freezy-sk avatar Oct 01 '19 06:10 freezy-sk

can you add tests with different timezones?

tattali avatar Oct 02 '19 08:10 tattali

@tattali of course. do you want come complex testing or just unit tests?

freezy-sk avatar Oct 05 '19 17:10 freezy-sk

what do you mean about complex testing ?

tattali avatar Oct 05 '19 18:10 tattali

Will be nice to fix and merge this feature, highly needed to prevent people to use whatever timezone they want without any trouble.

Grumshruk avatar Oct 22 '19 20:10 Grumshruk

@tattali under complex testing I meant something like integration tests with JS library

freezy-sk avatar Oct 23 '19 06:10 freezy-sk

there are no js in this project, php unit testing is enough

tattali avatar Oct 25 '19 21:10 tattali

Hello, what is the status of this issue?

danaki avatar May 05 '20 09:05 danaki

129.90s$ curl -s -o archive.tar.bz2 $archive_url && tar xjf archive.tar.bz2 --directory /
curl: (7) Failed to connect to storage.googleapis.com port 443: Connection timed out
0.00s0.02s$ phpenv global 7.3
rbenv: version `7.3' not installed
The command "phpenv global 7.3" failed and exited with 1 during .

Is just a technical issue of CI. Can you please let it go?

danaki avatar May 05 '20 09:05 danaki

This is not only a CI issue, there is just no tests for this feature

tattali avatar May 05 '20 10:05 tattali

There's not much to test, it just adds passed parameter.

danaki avatar May 05 '20 10:05 danaki

is this still going on?

fcaraballo avatar Jun 18 '21 23:06 fcaraballo

Close for inactivity

tattali avatar Mar 05 '24 22:03 tattali