go-fastping icon indicating copy to clipboard operation
go-fastping copied to clipboard

Published 20 hours ago • verified publisher icon tatsushid

Pass the data with the message in case there is a payload

Open kkirsche opened this issue 10 years ago • 5 comments

Allow the user to decide if they need the payload of the packet itself. This passes the data back to the user so that they can process it if desired.

kkirsche avatar Oct 22 '15 14:10 kkirsche

This uses []uint8 type for a payload value but []byte is better. Indeed, byte is uint8 alias but according to https://godoc.org/golang.org/x/net/icmp#Echo, Data is defined as []byte so using []byte is less confusing.

tatsushid avatar Oct 25 '15 03:10 tatsushid

Fixed @tatsushid — thanks for the feedback

kkirsche avatar Oct 25 '15 23:10 kkirsche

Sorry for the late reply.

The code looks good! Thanks for fixing it. This code includes a little API change and it would break the code which uses this library so I will announce about it and merge later.

tatsushid avatar Dec 05 '15 04:12 tatsushid

I wanted to follow up on this and see what your plans were regarding this?

kkirsche avatar Jan 18 '16 19:01 kkirsche

Following up on this, will this be merged?

kkirsche avatar Aug 14 '16 19:08 kkirsche