Tatsuhiro Tsujikawa comments

Results 428 comments of


                                            Tatsuhiro Tsujikawa

build error

ngtcp2_crypto_boringssl.h includes openssl/ssl.h which defines enum ssl_encryption_level_t. This kind of build error most likely comes when openssl/ssl.h is not a header file of boringssl. Instead it might be another openssl...

Move the parse of session->ob_reg after session->ob_syn.

I tend to disagree with this change. While this change might help the particular use case for envoy, other applications might want the current ordering of frames. In general, I...

Move the parse of session->ob_reg after session->ob_syn.

It says nothing about extension frames. There is a frame which can be sent before HEADERS (e.g., PRIORITY).

CMakeLists(lib): add EXPORT unofficial-ngtcp2-config

Could you check the CI failure? It is named "unofficial", but this is the official ngtcp2 repository. Is it just a remnant of vcpkg patch that is surely "unofficial"?

Unable to reach ng maintainers through regular channels. (ngtcp2, nghttp3, nghttp2, aria2)

You can find my e-mail address in git log. See the e-mail attached to "Tatsuhiro Tsujikawa"

TLSServerContext (example code): session_ticket_key_ should be cleared before freeing using gnutls_memset

Good catch. Would you mind creating a PR?

Bump ubuntu base image in endpoint image

I built ngtcp2 interop image with custom entrypoint image as ubuntu 22.04 base, and all interop tests succeeded except for A which has a known issue (see https://github.com/quic-interop/quic-interop-runner/pull/376). > but...

cmake: Export wolfssl crypto backend lib as CMake target

Could you check the CI failures?

cmake: Export wolfssl crypto backend lib as CMake target

That might brake the existing builds which depends on the current behavior. I would be better to stick with autotools rather than making everything cmake. @vszakats What do you think...

cmake: Export wolfssl crypto backend lib as CMake target

If wolfssl cmake support lags behind, then there is no reason to solely rely on it. At least, it is required to fallback to pkg-config (current way to find the...