fin-ml icon indicating copy to clipboard operation
fin-ml copied to clipboard

Derivatives Hedging does not work with TensorFlow 2.0

Open domokane opened this issue 3 years ago • 5 comments

The Derivatives Hedging notebook in Chapter 9 does not work with the latest version of TensorFlow (Keras).

domokane avatar Jun 08 '21 15:06 domokane

Obviously it will not work. Stick to the python packages version mentioned in the repo. We will upgrade it later.

On Tue, Jun 8, 2021 at 11:43 AM domokane @.***> wrote:

The Derivatives Hedging notebook in Chapter 9 does not work with the latest version of TensorFlow (Keras).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tatsath/fin-ml/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGMAACUQTUAXSFRU7F4QSDTRY3CZANCNFSM46KHJW3A .

tatsath avatar Jun 08 '21 17:06 tatsath

I am disappointed at your tone. It would have been "obvious" to expect that a book published in 2020 would not use a library that was out of date for a year when it was published, and which has been significantly amended.

domokane avatar Jun 08 '21 17:06 domokane

Check requirement.txt. of the repo. Use that version only.

On Tuesday, June 8, 2021, domokane @.***> wrote:

Your book just says Tensorflow. So is this only for TensorFlow 1.0.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tatsath/fin-ml/issues/8#issuecomment-856972773, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGMAAGBZCXXHHY7Q4IRGJTTRZKJBANCNFSM46KHJW3A .

tatsath avatar Jun 09 '21 07:06 tatsath

Any idea when you might upgrade to Tensorflow 2 ? I'd like to recommend this book to students but not if the code is incompatible with the libraries already on their machines.

domokane avatar Nov 14 '21 07:11 domokane

Please stick to requirement.txt as of now. We will change it in the next version

tatsath avatar Jan 02 '22 01:01 tatsath