Tatiana Al-Chueyr comments

Results 150 comments of


                                            Tatiana Al-Chueyr

Leading run_raw_sql with a comment doesn't work

Thank you very much for the details, @jlaneve ! Complementing what @dimberman mentioned, the working example failed for me: ``` File "/Users/al-cht01/.virtualenvs/astro-sdk-tutorial/lib/python3.7/site-packages/airflow/models/abstractoperator.py", line 394, in render_template return value.resolve(context) File "/Users/al-cht01/.virtualenvs/astro-sdk-tutorial/lib/python3.7/site-packages/airflow/utils/session.py",...

Leading run_raw_sql with a comment doesn't work

This issue surfaced a limitation in the Astro Python SDK, and Daniel logged a follow-up ticket: https://github.com/astronomer/astro-sdk/issues/569

Leading run_raw_sql with a comment doesn't work

Additional information: * When trying to run the complete DAG in Airflow, @jlaneve confirmed he couldn't run the DAG. * It seems the working DAG works if each task is...

Allow user to customize table schema while creating

@utkarsharma2 as we discussed, the `BaseDatabase` has a `create_table` method which already uses the `table.columns`, which are in `SQLAlchemy` format :) So I believe it is just a matter of...

Create E2E DAG examples

@kaxil I believe the AWS exampleis missing, showing the usage of S3 and Redshift (which is not supported yet) We also don't have any DAGs mixing Astro operators with (non-Taskflow)...

Set the CI to run and publish benchmark reports once a week

Just giving additional information, this feature was requested by @vikramkoka during a meeting with him - and the goal is to make sure our benchmark results are always up-to-date with...

Fix temporary table name creation

@tetsuya111 that sounds like a great strategy, it should be simple to confirm the names generated are compatible with all the supported databases!

Users should be able to set `tmp_schema` for each connection

That's excellent feedback, @pgzmnk! A PR in progress (#140) addresses the same issue but uses a different approach. It allows users to define default values per DAG instead of relying...

Users should be able to set `tmp_schema` for each connection

@pgzmnk, One of the challenges in implementing the feature you describe, is that Postgres expects the connection extra property only to contain pre-defined Postgres connection fields: * https://airflow.apache.org/docs/apache-airflow-providers-postgres/stable/connections/postgres.html#howto-connection-postgres * https://github.com/apache/airflow/blob/59c450ee5425a2d23ef813dbf219cde14df7c85c/airflow/providers/postgres/hooks/postgres.py#L103-L111...

Users should be able to set `tmp_schema` for each connection

For those who may be interested, the issues that happened with Postgres when trying to use this approach are documented in the branch `temp-schema-from-conn`: https://github.com/astronomer/astro-sdk/commit/8b0dfecb41a036bd849c185ec49377c7938cb5db