Tate, Hongliang Tian
Tate, Hongliang Tian
@StevenJiang1110 Need to rebase the PR to fix the conflict. Thanks!
@StevenJiang1110 Sorry, you have to rebase it again 😅
The timeout design looks good. I didn't dive into the Hierarchical Timing Wheels scheme. But having a design backed by a paper looks promising to me. And I am hoping...
This is good perf improvement. But the implementation contains a bug... The offset should be calculated as follows. ``` offset += buf.as_slice().len() ``` Another thing is that the implementation should...
Great. Now we can submit a pull request.
Yes, it is intentionally left empty as the paper is not ready. We are still improving its quality. Thanks for your interest and stay tuned.
> This requires us to place the permission checks within the system call path, rather than in InodeHandle. Please do not remove permission checks from `InodeHandle`. Keeping the permission checks...
> I may post the justification for some utter changes here: > > ## Removal of the `VmIo` implementation of `VmSpace` > Efficient Reading/Writing in a virtual memory space can...
Most of the code looks good. But the `Page::drop` method needs to be revised extensively, I suppose. See my detailed comments above.
> > I think the names `forget` and `restore` should be re-considered. > > For forgetting and restoring the page handle, the naming is indeed not appropriate. I've renamed them...