Misskey account shows wrong domain on remote users having a conversation on the same remote instance

[trwnh]

Description

User [email protected] is talking with user [email protected] and I am on local.com

ST instead parses the mentions as @[email protected] and @[email protected]

The payload contains username: alice and host: remote.com but the host does not seem to be used for constructing a mention

Steps to reproduce

1. View a conversation between [email protected] and [email protected]

Expected behaviour

Mentions show up as @[email protected] and @[email protected], which resolve correctly

Actual behavior

Mentions show up as @[email protected] and @[email protected], which do not load because they do not exist

Misc

• local.com is running Misskey 12.100.2
• remote.com is currently having a Cloudflare DNS issue

[trwnh]

[tateisu]

in your example, what domain is misskey? what domain is not ?

my case problem not reproduced,

• view from misskey.io
• convesations fedibird.com(mastodon base) with mastodon2.juggler.jp(mastodon)

[trwnh]

both are misskey, sorry -- i only mentioned the misskey version of nya.social because that was accessible at the time i filed the issue, whereas misskey.bubbletea.dev was down (but still running misskey of course)

[trwnh]

to clarify: in the example above, i am on nya.social, and two users on misskey.bubbletea.dev were having a conversation. everyone in the screenshot is from bubbletea.

[trwnh]

reproduced just now with https://misskey.bubbletea.dev/notes/90u6bbov45

[trwnh]

• view from nya.social (misskey 12.110.1)
• status on misskey.bubbletea.dev (misskey 12.110.1)
• mention of a user on misskey.bubbletea.dev is incorrectly shown as a mention of a user on nya.social (which does not exist)
• • unperson.us is a mastodon instance and their content renders the mention correctly

[trwnh]

Status-URL: https://misskey.bubbletea.dev/notes/90u6bbov45
Date: 2022-05-28 20:14:28
From-Acct: [email protected]

@[email protected] @[email protected] wear more clothes! im always dying in summer vecause its impossible to wear any less
Status-Source: {
  "id": "81810d60f9ef76388ae3dd26",
  "createdAt": "2022-05-29T01:14:28.207Z",
  "userId": "817e70a291d87ec3a8261d5b",
  "user": {
    "id": "817e70a291d87ec3a8261d5b",
    "name": "noodle",
    "username": "pie",
    "host": "misskey.bubbletea.dev",
    "avatarUrl": "https://misskey.bubbletea.dev/files/webpublic-480a7db7-32e8-4d03-9a36-c9770f277e1e",
    "avatarBlurhash": "y,N,^;t6~Wofxaj[Iot6ayfRaffRoeWBs=ofbEbFRkRjay%LazRjj[j[ayWUoffPRkjuoLayoft6ayWCoeoffkWBaffia{WCofofWB",
    "avatarColor": null,
    "instance": {
      "name": "bubbletea.dev",
      "softwareName": "misskey",
      "softwareVersion": "12.110.1",
      "iconUrl": "https://misskey.bubbletea.dev/static-assets/icons/192.png",
      "faviconUrl": "https://misskey.bubbletea.dev/files/256d675b-5548-426c-92e4-510c4f09487b",
      "themeColor": "#86b300"
    },
    "emojis": [],
    "onlineStatus": "unknown",
    "_fromStream": false
  },
  "text": "@shibao @[email protected] wear more clothes! im always dying in summer vecause its impossible to wear any less",
  "cw": null,
  "visibility": "public",
  "renoteCount": 0,
  "repliesCount": 1,
  "reactions": {},
  "emojis": [],
  "fileIds": [],
  "files": [],
  "replyId": "81810d60116b9588c5110cb9",
  "renoteId": null,
  "mentions": [
    "817ab2d3c10b822064df6b1c",
    "817fef9ccdd1e944e1571c8e"
  ],
  "uri": "https://misskey.bubbletea.dev/notes/90u6bbov45",
  "reply": {
    "id": "81810d60116b9588c5110cb9",
    "createdAt": "2022-05-29T01:13:28.683Z",
    "userId": "817ab2d3c10b822064df6b1c",
    "user": {
      "id": "817ab2d3c10b822064df6b1c",
      "name": "受不了包",
      "username": "shibao",
      "host": "misskey.bubbletea.dev",
      "avatarUrl": "https://misskey.bubbletea.dev/files/webpublic-f7c7706f-070e-47b8-838f-fdb02b45f7f0",
      "avatarBlurhash": "yFEnt{EN02%0-;f7Io0O-T={EN$zofs.IAI;~BxZ0zn%S5XnWVE2xZ-TR*%1^jxZIVIpozofR*E2NI%2xZRjs,WBe.s-flbIjYI;W=",
      "avatarColor": null,
      "instance": {
        "name": "bubbletea.dev",
        "softwareName": "misskey",
        "softwareVersion": "12.110.1",
        "iconUrl": "https://misskey.bubbletea.dev/static-assets/icons/192.png",
        "faviconUrl": "https://misskey.bubbletea.dev/files/256d675b-5548-426c-92e4-510c4f09487b",
        "themeColor": "#86b300"
      },
      "emojis": [],
      "onlineStatus": "unknown",
      "_fromStream": false
    },
    "text": "@[email protected] i am always too cold in winter 😭",
    "cw": null,
    "visibility": "public",
    "renoteCount": 0,
    "repliesCount": 1,
    "reactions": {},
    "emojis": [],
    "fileIds": [],
    "files": [],
    "replyId": "81810d5d865020bae221c4bc",
    "renoteId": null,
    "mentions": ["817fef9ccdd1e944e1571c8e"],
    "uri": "https://misskey.bubbletea.dev/notes/90u6a1rfft",
    "_fromStream": false
  },
  "_fromStream": false
}

what appears to be happening is because of the content not including a domain. subway tooter assumes your domain instead of the author's domain. it should be author's domain because the mention is local to the author, not to you.

[tateisu]

fixed at f57ac32c78c4f32eab7c66d40b668eb62ecc2756

[tateisu]

I believe this have been fixed.