splinepy icon indicating copy to clipboard operation
splinepy copied to clipboard

I got tired of copy pasting it for every illustration

Open jzwar opened this issue 1 year ago • 3 comments

Overview

See title

Addressed issues

  • I was annoyed by it

Showcase

a = sp.helpme.create.box(1,1)
TU_COLORS = sp.helpme.visualize._TUWIEN_COLOR_SCHEME
a.show_options["c"] = TU_COLORS["grey_1"]
a.show_options["control_mesh"] = False
a.show_options["control_point_c"] = TU_COLORS["black"]  # or "black"
a.show_options["knot_c"] = TU_COLORS["blue"]
a.show_options["control_point_ids"] = False
a.show()
image

Checklists

  • [ ] Documentations are up-to-date.
  • [ ] Added example(s)
  • [ ] Added test(s)

jzwar avatar Mar 13 '24 13:03 jzwar

I am not sure if this is something for splinepy. maybe gustaf? or a minimal external library?

j042 avatar May 07 '24 07:05 j042

thoughts @clemens-fricke ?

j042 avatar May 07 '24 07:05 j042

I thought about maybe adding a color map lookup to a file. If it is there show a debug warning that we will use the external colormap. If the colormap file is in the run folder or something? Shouldn't be that hard to implement. And elevates the problem without adding an institution-specific colormap into our code.

But I don't know how you can document this easily so that people know about it.

I can implement this if you want. Might also need to protect against code execution when reading the file.

Also, we could add it to the tataratat/samples repo and have a dynamic download if you choose this color map/chart.

clemens-fricke avatar May 08 '24 06:05 clemens-fricke

I thought about maybe adding a color map lookup to a file. If it is there show a debug warning that we will use the external colormap. If the colormap file is in the run folder or something? Shouldn't be that hard to implement. And elevates the problem without adding an institution-specific colormap into our code.

But I don't know how you can document this easily so that people know about it.

I can implement this if you want. Might also need to protect against code execution when reading the file.

Also, we could add it to the tataratat/samples repo and have a dynamic download if you choose this color map/chart.

sounds good. it's probably more useful after implementing default options. that way, we can call it (as other libraries do) "themes".

j042 avatar Jun 26 '24 19:06 j042

Due to inactivity, closing for now. Feel free to reopen this.

j042 avatar Jul 23 '24 12:07 j042