todomvc icon indicating copy to clipboard operation
todomvc copied to clipboard

Changing todos title to its page title in React Js Example

Open andrehgdias opened this issue 5 years ago • 3 comments

Partial solution/adition to #1977 with pretty simple changes:

  • The h1 title element sets its inner HTML with page title (in examples/react/js/app.jsx)
  • Css property font-size and top, from .todoapp h1, altered to fit its page title text ( examples/react/node_modules/todomvc-app-css/index.css).

Just need to know if it's okay to do these alterations.

andrehgdias avatar Oct 23 '19 22:10 andrehgdias

This looks fine to me, despite the failing build (@FadySamirSadek, can you advise on missing env variables?)

If a core team member agrees, I would prefer updating all example apps in this way in one PR as opposed to a separate PR for each. You could continue updating this branch until they are all done AFAIC.

lyndseypadget avatar Oct 25 '19 15:10 lyndseypadget

That's ok to me, but I can work only on a few of the examples since I'm still studying JavaScript programming and its huge ecosystem.

andrehgdias avatar Oct 25 '19 18:10 andrehgdias

This looks fine to me, despite the failing build (@FadySamirSadek, can you advise on missing env variables?

The test suite is currently broken but I'm working to fix that.

If a core team member agrees, I would prefer updating all example apps in this way in one PR as opposed to a separate PR for each. You could continue updating this branch until they are all done AFAIC.

I agree this should be done in a single PR. If you can work with @andrehgdias on that, it would be great.

FadySamirSadek avatar Oct 27 '19 08:10 FadySamirSadek