todomvc
todomvc copied to clipboard
Changing todos title to its page title in React Js Example
Partial solution/adition to #1977 with pretty simple changes:
- The h1 title element sets its inner HTML with page title (in examples/react/js/app.jsx)
- Css property font-size and top, from .todoapp h1, altered to fit its page title text ( examples/react/node_modules/todomvc-app-css/index.css).
Just need to know if it's okay to do these alterations.
This looks fine to me, despite the failing build (@FadySamirSadek, can you advise on missing env variables?)
If a core team member agrees, I would prefer updating all example apps in this way in one PR as opposed to a separate PR for each. You could continue updating this branch until they are all done AFAIC.
That's ok to me, but I can work only on a few of the examples since I'm still studying JavaScript programming and its huge ecosystem.
This looks fine to me, despite the failing build (@FadySamirSadek, can you advise on missing env variables?
The test suite is currently broken but I'm working to fix that.
If a core team member agrees, I would prefer updating all example apps in this way in one PR as opposed to a separate PR for each. You could continue updating this branch until they are all done AFAIC.
I agree this should be done in a single PR. If you can work with @andrehgdias on that, it would be great.