todomvc
todomvc copied to clipboard
tastejs
Fix cypress test for dojo
Re #1866
The Dojo example fails all cypress tests relating to edit i.e.:
- should allow me to edit an item
- should save edits on blur
- should trim entered text
- should remove the item if an empty text string was entered
As far as I can tell in Todo.js - saveEdits() - newTitle does not reflect the value of the input. Note: it will pass the test every now and then 😢
Editing works fine in this example when performed manually.
@'ing the credited authors: @jthomas @edchat @asudoh
@kitsonk @dylans Are either of you interested in introducing Dojo2 example of TodoMVC (or is there one already)? Thanks!
@asudoh there’s a Dojo 2+ todomvc example at https://github.com/dojo/examples/tree/master/todo-mvc
@dylans Great to hear! Do you guys want to contribute the code here? Thanks!
@dylans Great to hear! Do you guys want to contribute the code here? Thanks!
The main reason we haven't is that with our examples repo, we're able to quickly iterate all of our examples with each new release in one place. That said, we're open to contributing the same code here if that's useful.
@dylans I think having the example in the TodoMVC Repo and on the website will be very useful to people who want to compare how Dojo works relative to other libraries/frameworks. Also, It may introduce new people to Dojo which is a good thing. WDYT ?
That's fine, though with the HNPWA demos, aren't you linking out to other repos/websites instead of maintaining your own copy? Mostly I'm just concerned with it getting stale... when it's in our examples repo, we keep it current, but when it's external we're more likely to forget about it as we introduce new releases.