todomvc icon indicating copy to clipboard operation
todomvc copied to clipboard

Published 20 hours ago • verified publisher icon tastejs

Typescript-Vue

Open victorgarciaesgi opened this issue 6 years ago • 3 comments

victorgarciaesgi avatar Feb 28 '18 18:02 victorgarciaesgi

Hello @victorgarciaesgi do you still want to merge this PR to todomvc? If so you would need to rebase your branch with the current master :blush: If not it is also okay and we could close this PR. :bowtie:

Fruitseller avatar Jun 27 '18 19:06 Fruitseller

Yes still want to! I just need to pull master right?

victorgarciaesgi avatar Jun 28 '18 15:06 victorgarciaesgi

@victorgarciaesgi I think rebasing would be a cleaner aproach for getting your PR up to date. You should also look if you codebase fulfills the app requirements.

And I think it would be great if you could write something about your motivations to add vue in TS to todomvc and also what the benefits are when its merged.😊

Fruitseller avatar Jun 28 '18 18:06 Fruitseller