React with ES6 and Webpack Implementation

[acamposruiz]

Hi!

Here I have develop an aproach with React 0.14 and webpack with ES6, I think can be a good thing present a way to modularize this project with webpack.

The project is in examples/react-webpack-es6.

Thanks for suggestions!

Antonio

[mention-bot]

@acamposruiz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sindresorhus and @passy to be potential reviewers.

[acamposruiz]

Hi @dhruvdutt , I have cleaned up my commit messages and rebasen as you asked in this new branch and Pull Request

[dhruvdutt]

Cool. Are there still issues with jshint in examples/react-webpack-es6/build/app.js?

[acamposruiz]

Appears that way so I will check all that and fix it as soon as I can

[acamposruiz]

I do not know if it is made a npm install on server on every project in order to let the example work out, do you know?

[acamposruiz]

I have that doubt because of node_modules folder is not included in .gitignore in other examples, why?

[acamposruiz]

In react example is included node_modules:

[acamposruiz]

Hi @dhruvdutt , Do you know anything about this error on travis? (node:9520) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead https://travis-ci.org/tastejs/todomvc/builds/269962365?utm_source=github_status&utm_medium=notification

[dhruvdutt]

Okay, the other examples have node_modules folder which includes the final dist only and not the src. I believe this must have been done to directly serve package assets through GitHub static hosting. The current node_modules seems too big to commit. How about we generate a single file app.js including all vendor code and commit it?

Not sure about travis-ci check. Some nested dep seems to cause the issue.

[acamposruiz]

I've already removed almost all node_modules, only todomvc dependences will remains there. But travis-ci issue keep stay there and it seems like it has been happening for a while, so many others contributions remains unmerge because of this. I really do not know how to deal with this but I will keep digging some days. :)

[FadySamirSadek]

@acamposruiz Are you still intrested in landing this ?

[acamposruiz]

@FadySamirSadek yeah I'm still interested ;), Do you want me to do anything? what's next?

[sagirk]

@acamposruiz

1. Branch has conflicts. Needs a rebase.
2. Build is failing. Something to do with tests in tests/memory.js.

[FadySamirSadek]

Please refer to #2219