taskiq-redis icon indicating copy to clipboard operation
taskiq-redis copied to clipboard

Variable `self._is_first_run` in ListRedisScheduleSource doesn't work

Open lryan599 opened this issue 8 months ago • 1 comments

https://github.com/taskiq-python/taskiq-redis/blob/513b77e12bd8424d433ef9f7101add2df138d688/taskiq_redis/list_schedule_source.py#L193

According to the comments, this condition should be

if not self._skip_past_schedules and self._is_first_run:

Otherwise, the variable self._is_first_run is not used at all.

lryan599 avatar May 08 '25 07:05 lryan599

Yeah. I should fix this comment. Because as it turned out, you should fetch previous schedules every time. Because otherwise you loose them completely.

s3rius avatar May 10 '25 22:05 s3rius