taskiq-redis icon indicating copy to clipboard operation
taskiq-redis copied to clipboard

Added redis sentinel support

Open DABND19 opened this issue 1 year ago • 3 comments
trafficstars

DABND19 avatar Apr 14 '24 13:04 DABND19

@s3rius Hello Pavel! I have added redis sentinel support to the taskiq-redis driver. The changes are backward compatible, but perhaps it could have been done more simply, as, for example, in dramatiq: https://github.com/Bogdanp/dramatiq/blob/master/dramatiq/brokers/redis.py#L99. But, as I understand it, the implementation of interaction with redis-py is specifically hidden in taskiq-redis.

DABND19 avatar Apr 20 '24 07:04 DABND19

Thanks for your PR.

But, as I understand it, the implementation of interaction with redis-py is specifically hidden in taskiq-redis.

You are correct, users should not bother themself with details.

s3rius avatar Apr 20 '24 09:04 s3rius

@s3rius Hello. All issues have been resolved. Can you approve the PR? And then merge it to the develop branch when you need it.

DABND19 avatar May 03 '24 18:05 DABND19

Thank you very-very much for your work. And sorry for such a delay.

Amazing work.

s3rius avatar Jun 11 '24 17:06 s3rius