taskiq-pipelines icon indicating copy to clipboard operation
taskiq-pipelines copied to clipboard

Switch to broker.serializer instead of JSON-only solution

Open asvetlov opened this issue 1 year ago • 2 comments

The code works well but contains a dirty hack for parsing pipeline data from task labels.

Pipeline loads()/dumps() are loadb()/dumpb() now.

Step's loads()/dumps() are gone away, seems like they don't override anything actually but all have the same code.

I'm not sure if the PR should be merged as is.

@s3rius please consider it as the idea demonstration.
If you agree with the code in general, I'll make bytes support to message labels first, and remove the hack later.

P.S. Sorry for two-week delay. Tests were hanging without any exception or log message. It took a while to figure out how to debug the problem.

asvetlov avatar Oct 29 '23 14:10 asvetlov

I also had no time to review it, sorry. Was busy as a bee on work.

s3rius avatar Nov 03 '23 13:11 s3rius

I also had no time to review it, sorry. Was busy as a bee on work.

Don't rush please, a few days don't change the university :)

asvetlov avatar Nov 06 '23 13:11 asvetlov