generic-worker icon indicating copy to clipboard operation
generic-worker copied to clipboard

publicIP and livelogSecret shouldn't be required

Open glandium opened this issue 6 years ago • 1 comments

A worker may not have a public IP address, which, AIUI, prevents livelog from working. That's fine. But generic-worker insists on having a publicIP set (setting it to 127.0.0.1 worked, but that is silly), and a livelogSecret (which setting to worked too). Instead of having to give bogus values, the properties should just instead be optional.

glandium avatar Jul 20 '18 00:07 glandium

Agreed. At this time it probably makes sense to introduce a json schema for the generic worker config file, so we can implement more sophisticated controls, e.g. if you enable livelog, you need a public IP, but if you don't, one shouldn't be needed, etc.

Thanks for raising!

petemoore avatar Jul 27 '18 18:07 petemoore