tasit-apps
tasit-apps copied to clipboard
tasitlabs
Erratic "My land" list behavior
https://youtu.be/Lg0bqZoW-QM
Note the count of land (4 vs. 5) and the ordering of the land
We may want to split this out into an issue about preserving the order of the land in the "My land" list and handling buys that may not have gone through enough to persist?
Second video:
https://youtu.be/EfiC6vovJl4
Here's a sequel to this video with the same account where the land later shows up in the "My land" screen. I missed recording one time in between where I opened the app and after first it showed no land and then showed the land bought in the previous video. In this video, it goes straight to showing that land:
https://youtu.be/ytxfClR51uo
I've clean up my app data and followed the below steps trying to reproduce these issues:
- Signup
- Buying a land (name: TOP)
- It's was added to MyLandScreen and removed from LandForSaleScreen correctly = Restarting app...
- MyLandScreen is OK
- Buying another land (Lucky Lands near DrgonCity)
- It's was added to MyLandScreen and removed from LandForSaleScreen
- The MyLand list is now: [Lucky Lands..., TOP] = Restarting app...
- After access the
MyLandScreenthe list was OK (from storage) but was refreshed with wrong sort (from blockchain) hypothesis: DecentralandUtils list is extracted following timeline of events solution: Do a revert operation on the list got from blockchain before update app state
I'll create a PR now with this fix, the other problem faced for you isn't clear to me yet. Could you help me to understand?
Did you do this test using develop branch or the PR branch? Is this related to https://github.com/tasitlabs/tasit/pull/260#issuecomment-481261606 ?
Did you do this test using
developbranch or the PR branch? Is this related to #260 (comment) ?
I'm 90% sure I did this test with the develop branch. Yes, that comment is related to this. It may address some or all of what I observed here - I'm not sure.
Do a revert operation
When you say revert do you mean reverse? "revert" means "undo" to me.
the other problem faced for you isn't clear to me yet. Could you help me to understand?
Sure, I can create a text transcript of the videos like you did. Maybe the exact timing is important.
The solution you proposed above for what you saw sounds good. I agree that most of what you saw was as expected, so those steps didn't reproduce the bugs I observed.
Do a revert operation
When you say revert do you mean reverse? "revert" means "undo" to me.
Oh, sorry. I've meant "reverse list".