tasit-apps icon indicating copy to clipboard operation
tasit-apps copied to clipboard

Some parcel buys not successfully completing

Open pcowgill opened this issue 5 years ago • 6 comments

@marcelomorgado Have you experienced this?

"Parcel without name" for 44000 MANA reappears for sale after app update, when I bought it and it was showing up in the My Assets view before the app update

pcowgill avatar Mar 27 '19 19:03 pcowgill

For what it's worth, I wasn't able to reproduce this just now when I tried it on Android. Maybe it wasn't really exactly the same parcel of land? Or maybe the populate land script readded a similar piece of land after I bought it and I confused the two? I'll see if I can reproduce this.

pcowgill avatar Mar 27 '19 20:03 pcowgill

It also reappears after quitting and reinstalling the app.

So I think we're just not checking for previously bought assets before putting the results of the assets for sale fetch into redux on first app load.

Here are iOS steps to reproduce:

IMG_3837 IMG_3838

Quit app and reopen.

IMG_3839 IMG_3841

pcowgill avatar Mar 27 '19 21:03 pcowgill

I've figured out what is happening, the purchase is only working for estate assets. That parcel isn't being shown on the main list because the order wasn't be executed. I'll look into that as a top priority.

marcelomorgado avatar Mar 27 '19 21:03 marcelomorgado

Ah ok interesting - good find. In that case we should also update the logic for when the "purchase successful" notification is shown

pcowgill avatar Mar 27 '19 22:03 pcowgill

Ah ok interesting - good find. In that case we should also update the logic for when the "purchase successful" notification is shown

Ok, brought https://github.com/tasitlabs/tasit/issues/151 to 0.1.0 milestone

marcelomorgado avatar Mar 27 '19 22:03 marcelomorgado

Perfect, thanks

pcowgill avatar Mar 27 '19 22:03 pcowgill