tasit-apps
tasit-apps copied to clipboard
tasitlabs
Using events and/or action confirmation listeners instead of `waitForOneConfirmation`
@pcowgill commented:
I'm wondering whether the await style still makes sense for higher-level functions that wrap Ethereum interactions. I think it doesn't but we'll want to set best practices for the right pattern when using this style to not end up in nested "callback hell"
The callback style of listening for success with a subscription/callback makes the most sense when used along with optimistic updates, which we aren't doing here yet.
Refs: https://github.com/tasitlabs/tasit/pull/163#discussion_r267405172
@marcelomorgado I think this will follow nicely after the SDK updates. Using conf’s is worth considering in combination with or as an alternative to using events
Yes, we are almost there, I think we have only a few bugs to fix before to do this. https://github.com/tasitlabs/TasitSDK/issues/368, https://github.com/tasitlabs/TasitSDK/issues/367, https://github.com/tasitlabs/TasitSDK/issues/366
Yes, we are almost there, I think we have only a few bugs to fix before to do this. tasitlabs/TasitSDK#368, tasitlabs/TasitSDK#367, tasitlabs/TasitSDK#366
Great! And yep, agreed that those are gating. Thanks for sharing the specific issues.
Updating:
~~https://github.com/tasitlabs/TasitSDK/issues/368~~ Closed https://github.com/tasitlabs/TasitSDK/issues/367 fixed on PR https://github.com/tasitlabs/TasitSDK/pull/383
I think that issue https://github.com/tasitlabs/TasitSDK/issues/384 should be solved as well.
Updating:
~tasitlabs/TasitSDK#368~ Closed tasitlabs/TasitSDK#367 fixed on PR tasitlabs/TasitSDK#383
Great!