tasit-apps icon indicating copy to clipboard operation
tasit-apps copied to clipboard

Add starting ganache to the npm start script for the demo app

Open pcowgill opened this issue 5 years ago • 6 comments

pcowgill avatar Feb 21 '19 17:02 pcowgill

Note: Populate estates script is now (from https://github.com/tasitlabs/TasitSDK/pull/249) running together migrations scripts.

marcelomorgado avatar Mar 11 '19 12:03 marcelomorgado

Isn't clear to me how we'll start ganache process from tasit project because tasit isn't aware were TasitSDK folder is. Is the blockchain connection check enough?

marcelomorgado avatar Mar 11 '19 15:03 marcelomorgado

I guess we might want to call the command to start it the same way a project would want to call expo-cli commands from within an expo project. Maybe this means the ganache commands belong in tasit-cli and then we use ganache via tasit-cli in both the SDK tests and in the tasit apps when running in local dev mode? That may be trickier than I’m picturing though - I’ll give it more thought.

pcowgill avatar Mar 11 '19 18:03 pcowgill

Regardless, in the short term and medium term the connection check alone will serve us really well! Great work!

pcowgill avatar Mar 11 '19 18:03 pcowgill

I guess we might want to call the command to start it the same way a project would want to call expo-cli commands from within an expo project. Maybe this means the ganache commands belong in tasit-cli and then we use ganache via tasit-cli in both the SDK tests and in the tasit apps when running in local dev mode? That may be trickier than I’m picturing though - I’ll give it more thought.

I see, but will start ganache on starting for our apps only right? If dev will working on their ganache/truffle env I think that he will want to start the ganache for their own. Is it right?

Regardless, in the short term and medium term the connection check alone will serve us really well! Great work!

Thanks! Should we rename the issue and move to a future milestone?

marcelomorgado avatar Mar 11 '19 18:03 marcelomorgado

I guess if a dev is working with their own ganache / truffle env, if the team is big enough to specialize, the mobile dev still might forget to start ganache. But yeah that's a good point - for now let's just assume ganache should be started separately.

Sure, renaming the issue and moving to a future milestone sounds good.

pcowgill avatar Mar 12 '19 17:03 pcowgill