observable icon indicating copy to clipboard operation
observable copied to clipboard

Crash when try to check Results | 1.18.2

Open 6e3noHToBui opened this issue 1 year ago • 4 comments

After profiling, try to seen all results and minecraft closing. Crash log: bruh

6e3noHToBui avatar May 19 '23 10:05 6e3noHToBui

Sounds like a duplicate of #12. From my observations, the issue is fairly infrequent, so it should function when you open the game again. I fixed the issue for 1.19 but didn't backport it to 1.18 yet.

tasgon avatar May 19 '23 20:05 tasgon

Okay, thanks, we'll be waiting it in 1.18

6e3noHToBui avatar May 19 '23 21:05 6e3noHToBui

I can backport a fix to 1.18 if you could mention commit hash with a potential fix.

andriihorpenko avatar May 24 '23 17:05 andriihorpenko

The fix was to completely scrap the in-game results window and replace it with the online service at https://o.tas.sh. Technically, the 1.18-online branch should already have most of the changes, but I didn't have enough time then to test and release a new version with the changes.

@andriihorpenko If you're interested in helping, I'd recommend pulling that branch and testing it out to see if it works, then comparing it with the current 1.19 codebase to see if anything else relevant would need to be backported.

tasgon avatar May 25 '23 02:05 tasgon