django-messages-drf
django-messages-drf copied to clipboard
tarsil
Improved docs
Solves an issue.
Changes:
- [x] List of original URLs with parameters
- [x] Expanded information about creating thread functionality
- [x] Introduction to the main logic - app-initiating-threads is actually a message sending functionality (that have option to be replied to within existing already premade thread.)
- [x] New theme - slate.
TODO:
- Verify docs on local by executing (Mac):
bundle exec middleman build --clean
- Run script to deploy on gh-pages branch by running:
./deploy
from within docs folder.
You are a machine!! Unfortunately today I have no time to review but I will do it soon. Promise. For what I looked it should be ok as is and a great improvement in so many levels. Love it
Beautiful!!!!! πππππ. Way better than before. Evolution. You're a star.
Regarding the logo. Well I built all logos before but not for this one. I can think of something if you want
Actually it's even better than the one I had in mind. Related with DRF and unique. This one is perfect actually
@hvitis i do really apologise as I thought I already had merged this!! My God, I missed out it this bit.
It has been a hectic few months with a lot going on but I will definitely merge your changes but I will need to update the CI.
It is using an old version and I want to move to GActions.
I could even put you as a maintainer if you want? :)
Once again, I do really apologise.
P.S.: I'm still not sure if all of these files are needed or auto generated
Hey. Sure. Put me as a maintainer, cancel this PR and put a list of changes you'd like to see implemented. I'll see what I can do!
So, I didn't mean to disrespect you by thinking i did it before and apparently it was forgotten. So sorry.
What I would say we could start would be:
- Move away from circle CI and into GitHub actions. I did something like that with Django Tenants URL. This will allow not only to add support for python 3.11 but also remove from 3.7.
- Your documentation idea is amazing.
- The same for your logo.
- Add a workflow to publish a version every time a new tag is created or push to the repo. I can do this one but it will follow the same lines as this one example
You are now a maintainer so you can also improve as you see fit. I'm 100% sure that you now use it more than I do unfortunately. I'm maintaining Esmerald and Edgy and few others which takes majority of my time.
P.S.: You might have received the invite already to join the repo. Feel free to reuse this or simply open a new one. A good plan is ok ππΌ
Hey! No worries at all! I was rushing and answering from my mobile. I think the outcome is:
- I will recheck this PR to delete redundant files
- I will merge it and verify the new layout
- I will move to deploying via GH actions and create z separate future PR for it Then we will chat! :)
Thanks and let's keep in touch.
Thank you so much @hvitis i really do appreciate that from you. Just accept the invite.
By the way, you seem someone that likes python a lot and playing around. What if you have a look at Esmerald and tell what do you think? Do you think it is something that it might be of interest of you? Maybe maintainer as well if you like and played around?
I did accept it now. I have seen your projects but I am mainly working with Django. Maybe a younger audience interested in new frameworks would be a good targets?
czw., 31 sie 2023 o 17:23 Tiago Silva @.***> napisaΕ(a):
Thank you so much @hvitis https://github.com/hvitis i really do appreciate that from you. Just accept the invite.
By the way, you seem someone that likes python a lot and playing around. What if you have a look at Esmerald https://esmerald.dev and tell what do you think? Do you think it is something that it might be of interest of you? Maybe maintainer as well if you like and played around?
β Reply to this email directly, view it on GitHub https://github.com/tarsil/django-messages-drf/pull/21#issuecomment-1701254374, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECP234E4HYKDBGR6YC65CLXYCT7BANCNFSM6AAAAAAXG4PHUA . You are receiving this because you were mentioned.Message ID: @.***>
I did accept it now. I have seen your projects but I am mainly working with Django. Maybe a younger audience interested in new frameworks would be a good targets? czw., 31 sie 2023 o 17:23 Tiago Silva @.> napisaΕ(a): β¦ Thank you so much @hvitis https://github.com/hvitis i really do appreciate that from you. Just accept the invite. By the way, you seem someone that likes python a lot and playing around. What if you have a look at Esmerald https://esmerald.dev and tell what do you think? Do you think it is something that it might be of interest of you? Maybe maintainer as well if you like and played around? β Reply to this email directly, view it on GitHub <#21 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECP234E4HYKDBGR6YC65CLXYCT7BANCNFSM6AAAAAAXG4PHUA . You are receiving this because you were mentioned.Message ID: @.>
It might be an idea as this is more of an alternative, scalable and simply different :)