Thiago Padilha

Results 136 comments of Thiago Padilha

Hi @edsiper ! Not sure if you saw, but a few months ago I created a PR which exposes log metadata to Lua in a backwards compatible way: https://github.com/fluent/fluent-bit/pull/9323/ ....

No idea, though it has been 9 years since I did those changes so I barely remember anything about this. @fumoboy007 can you check if this test fails on commits...

@DouweM CI still failing on code coverage. I will fix it, but first I'd love some feedback on the API . LMK if you agree with the choices or if...

> @tarruda I just noticed I never submitted the review I did many weeks ago 🤦🏻 @DouweM and I completely missed the notification of you submitting the review 🤦🏻 Can...

@DouweM I merged main (lots of conflicts :sweat:) Also addressed your review!

I've been delaying dicussing this until later, but a refactor in the command-line code may be required for the first release. The reason is that command-line, just like interactive ex...

> UPDATE: I think I get it now. I had taken g:enhanced_command_line for a constant option. But I suppose the intent is to change it just before/after command line is...

We would still have the current command window. The idea is to give it some enhancements(enabled when invoked with `:`) that made it a drop-in replacement for the command line

> Now, imagine we have an improved command-window, which can be launched two ways (single-line and multi-line). And that command window's insert mode is able to completely emulate previous command...

> But then, how would things like command mode mappings work? I suppose a command mode mapping would translate into an insert mode mapping restricted to a particular buffer (command...