Cory Forsstrom
Cory Forsstrom
Agreed, I've thought about it more and with the module system in gleam I think it makes a lot of sense. I'll update the draft to include this change.
I've updated the draft with this change. Not only does it simplify the implementation (we can just append origin path + module name + .gleam), but it fundamentally makes sense...
Absolutely! I've moved this to draft for now and created an issue here: https://github.com/gleam-lang/gleam/issues/4894
> Is this ready for review? Yup! I've just moved it off draft.
Thanks for the feedback @lpil! I've addressed your comments, let me know if there is anything else that should be addressed.
@lpil Thanks! Tests are added. Let me know what you think of the refactoring needed to support defining an origin & module with `TestProject::at` in a backwards compatible way.
@lpil Appreciate the great feedback. I've addressed your comments, though see https://github.com/gleam-lang/gleam/pull/4888#discussion_r2323652837
Hey @lpil checking in on this, can I get another review / finalize a decision on https://github.com/gleam-lang/gleam/pull/4888#discussion_r2328702587? I've rebased and this is otherwise good to go.
> Why is it that the tests need to be made so much more complex? All changes revolve around needing a `TestProject::in_module_at` function that allows me to trigger the code...